Skip to content

Bug 1810470: Verify pending volume modifications and size both #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Sep 1, 2020
Merged

Bug 1810470: Verify pending volume modifications and size both #165

openshift-merge-robot merged 1 commit into from
Sep 1, 2020

Conversation

@gnufied
Copy link
Member

@gnufied gnufied commented Sep 1, 2020

When returning successful for volume expansion requests we should
verify both volume size reported via DescribeVolume and pending volume
modifications requests

@gnufied
carry: Verify pending volume modifications and size both
0a5ae88 
When returning successful for volume expansion requests we should
verify both volume size reported via DescribeVolume and pending volume
modifications requests
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 1, 2020
@gnufied gnufied changed the title carry: Verify pending volume modifications and size both Bug 1810470: Verify pending volume modifications and size both Sep 1, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Sep 1, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 1, 2020

@gnufied: This pull request references Bugzilla bug 1810470, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1810470: Verify pending volume modifications and size both

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gnufied
Copy link
Member Author

gnufied commented Sep 1, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 1, 2020

@gnufied: This pull request references Bugzilla bug 1810470, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bertinatto
bertinatto reviewed Sep 1, 2020
View reviewed changes
Copy link
Member

@bertinatto bertinatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 1, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 1, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, gnufied

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit be3f45e into openshift:master Sep 1, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 1, 2020

@gnufied: All pull requests linked via external trackers have merged:

Bugzilla bug 1810470 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1810470: Verify pending volume modifications and size both

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot mentioned this pull request Sep 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bertinatto bertinatto bertinatto left review comments

@huffmanca huffmanca Awaiting requested review from huffmanca

@jsafrane jsafrane Awaiting requested review from jsafrane

Assignees

@bertinatto bertinatto

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gnufied @openshift-ci-robot @bertinatto @openshift-merge-robot